Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HI MEs to per-LS scope in JetMET offline DQM - backport to 14_1_X #46605

Open
wants to merge 1 commit into
base: CMSSW_14_1_X
Choose a base branch
from

Conversation

rseidita
Copy link
Contributor

@rseidita rseidita commented Nov 5, 2024

PR description:

Adding the following MEs to the per-LS scope:

JetMET/HIJetValidation/akCs4PFJets/SumPFPt
JetMET/HIJetValidation/akCs4PFJets/NJets
JetMET/HIJetValidation/akCs4PFJets/NPFpart
JetMET/HIJetValidation/akPu4CaloJets/SumCaloPt
JetMET/HIJetValidation/akPu4CaloJets/NCalopart
JetMET/HIJetValidation/akPu4CaloJets/NJets

PR validation:

Tested running the @jetmet sequence on run 375703 HIMinimumBias0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #46548

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Nov 5, 2024
@rseidita rseidita changed the title Adding HI MEs to per-LS scope in JetMET offline DQM Adding HI MEs to per-LS scope in JetMET offline DQM - backport to 14_1_X Nov 5, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2024

A new Pull Request was created by @rseidita for CMSSW_14_1_X.

It involves the following packages:

  • DQMServices/Core (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2024

cms-bot internal usage

@rseidita
Copy link
Contributor Author

rseidita commented Nov 5, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33908d/42592/summary.html
COMMIT: 3018d42
CMSSW: CMSSW_14_1_X_2024-11-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46605/42592/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565669
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565649
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@antoniovagnerini
Copy link

backport of #46548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants