Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caloParams v0_0 for 2024 HI run #46593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rohitcms
Copy link

@rohitcms rohitcms commented Nov 3, 2024

PR description:
Add L1T calo configs for heavy ion with updated centrality trigger thresholds for use in the 2024 run, taking into account the HF response corrections.

PR validation:
These files represent L1 configuration to be stored centrally, and are not involved in any central workflows.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport. Will need to backport to CMSSW_14_1_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46593/42490

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2024

A new Pull Request was created by @rohitcms for master.

It involves the following packages:

  • L1Trigger/Configuration (l1)
  • L1Trigger/L1TCalorimeter (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98434a/42626/summary.html
COMMIT: 83ebe1b
CMSSW: CMSSW_14_2_X_2024-11-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46593/42626/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3343138
  • DQMHistoTests: Total failures: 406
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342712
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 195 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants