Removed FwkJob category from MessageLogger config #31874

Dr15Jones · 2020-10-20T15:38:18Z

PR description:

The FwkJob category has not been supported for many years.
These changes are needed to be able to remove the default setup of FwkJob from within MessageLogger itself.

Other uses of FwkJob in CMSSW declare the category explicitly so are not dependent upon a change to MessageLogger.

PR validation:

The FwkJob category has not been supported for many years. These changes are needed to be able to remove the default setup of FwkJob from within MessageLogger itself.

cmsbuild · 2020-10-20T15:38:39Z

The code-checks are being triggered in jenkins.

Dr15Jones · 2020-10-20T15:39:42Z

@makortel FYI

cmsbuild · 2020-10-20T15:44:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31874/19254

This PR adds an extra 44KB to repository

cmsbuild · 2020-10-20T15:44:47Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Calibration/EcalAlCaRecoProducers
DQM/CSCMonitorModule
DQMOffline/CalibMuon
DQMOffline/Muon
EventFilter/L1GlobalTriggerRawToDigi
L1Trigger/GlobalTriggerAnalyzer
RecoTracker/CkfPattern

@perrotta, @benkrikler, @yuanchao, @kmaeshima, @tlampen, @christopheralanwest, @andrius-k, @tocheng, @ErnestaP, @cmsbuild, @rekovic, @jfernan2, @fioriNTU, @slava77, @jpata, @pohsun can you please review it and eventually sign? Thanks.
@felicepantaleo, @abbiendi, @argiro, @Martin-Grunewald, @thomreis, @mmusich, @cericeci, @battibass, @makortel, @JanFSchulte, @jhgoh, @HuguesBrun, @ptcox, @trocino, @rociovilar, @barvic, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @tocheng, @mschrode, @ebrondol, @mtosi, @dgulhan, @rchatter, @Fedespring, @calderona, @gpetruc, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2020-10-20T15:45:28Z

please test

cmsbuild · 2020-10-20T15:45:52Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-19-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10140/console Started: 2020/10/20 17:46

cmsbuild · 2020-10-20T20:10:48Z

+1
Tested at: cac0b7e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6573c0/10140/summary.html
CMSSW: CMSSW_11_2_X_2020-10-19-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Removed unused fwkJobReports from MessageLogger in Geometry Subsystem #31858 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in Geometry Subsystem
Added LogFwk* logging levels to be used by the framework #31815 @Dr15Jones: Added LogFwk* logging levels to be used by the framework
Sub-event aware genJet and parton matching for HI miniAOD #31698 @mandrenguyen: Sub-event aware genJet and parton matching for HI miniAOD
ES DQM: Enable concurrent processing of lumisections #31829 @tanmaymudholkar: ES DQM: Enable concurrent processing of lumisections
Add anti-electron tauID for phase2 #31470 @cms-tau-pog: Add anti-electron tauID for phase2
Add maximum of pileup pT hats in JME custom NanoAOD #31831 @nurfikri89: Add maximum of pileup pT hats in JME custom NanoAOD
Nano gen dqm #31591 @kdlong: Nano gen dqm
Removed unused fwkJobReports from MessageLogger from DQMServices Subsystem #31855 @Dr15Jones: Removed unused fwkJobReports from MessageLogger from DQMServices Subsystem
Removed unused fwkJobReports from MessageLogger in Validation Subsystem #31862 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in Validation Subsystem
Removed unused fwkJobReports from MessageLogger in SLHCUpgradeSimulations Subsystem #31861 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in SLHCUpgradeSimulations Subsystem
Removed unused fwkJobReports from MessageLogger in IOMC Subsystem #31860 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in IOMC Subsystem
Removed unused fwkJobReports from MessageLogger in GeneratorInterface Subsystem #31857 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in GeneratorInterface Subsystem

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6573c0/10140/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6573c0/10140/git-merge-result

cmsbuild · 2020-10-20T20:10:51Z

Comparison job queued.

cmsbuild · 2020-10-20T21:22:04Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6573c0/10140/summary.html

The workflows 158.01 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 31 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2415615
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2415586
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 4.653 KiB( 32 files compared)
DQMHistoSizes: changed ( 1325.7 ): 4.653 KiB Physics/NanoAODDQM
Checked 142 log files, 21 edm output root files, 35 DQM output files

perrotta · 2020-10-21T08:00:17Z

please test
(to get rid of the differences in reco outputs likely due to the extra commits tested together with this purely technical pull request)

cmsbuild · 2020-10-21T08:00:42Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-20-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10168/console Started: 2020/10/21 10:02

cmsbuild · 2020-10-21T09:18:35Z

+1
Tested at: cac0b7e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6573c0/10168/summary.html
CMSSW: CMSSW_11_2_X_2020-10-20-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-21T09:18:38Z

Comparison job queued.

cmsbuild · 2020-10-21T10:33:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6573c0/10168/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2544100
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2544071
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

jfernan2 · 2020-10-21T11:20:24Z

+1

perrotta · 2020-10-21T11:41:18Z

+1

technical for reco
jenkins tests pass

christopheralanwest · 2020-10-21T13:18:09Z

+alca

silviodonato · 2020-10-22T08:55:55Z

merge

Removed FwkJob category from MessageLogger config

cac0b7e

The FwkJob category has not been supported for many years. These changes are needed to be able to remove the default setup of FwkJob from within MessageLogger itself.

cmsbuild added this to the CMSSW_11_2_X milestone Oct 20, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending dqm-pending l1-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 20, 2020

cmsbuild removed the code-checks-pending label Oct 20, 2020

cmsbuild added the code-checks-approved label Oct 20, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 20, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 20, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 20, 2020

cmsbuild removed the comparison-available label Oct 21, 2020

cmsbuild added comparison-pending tests-pending and removed tests-approved labels Oct 21, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 21, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 21, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 21, 2020

cmsbuild added dqm-approved and removed dqm-pending labels Oct 21, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 21, 2020

cmsbuild added alca-approved and removed alca-pending labels Oct 21, 2020

Dr15Jones mentioned this pull request Oct 21, 2020

Remove obsolete MessageLogger configuration options #31888

Merged

cmsbuild added orp-approved and removed orp-pending labels Oct 22, 2020

cmsbuild merged commit e02d303 into cms-sw:master Oct 22, 2020

Dr15Jones deleted the rmFwkJob branch October 22, 2020 20:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed FwkJob category from MessageLogger config #31874

Removed FwkJob category from MessageLogger config #31874

Dr15Jones commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

Dr15Jones commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

Dr15Jones commented Oct 20, 2020

cmsbuild commented Oct 20, 2020 •

edited

Loading

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

perrotta commented Oct 21, 2020

cmsbuild commented Oct 21, 2020 •

edited

Loading

cmsbuild commented Oct 21, 2020

cmsbuild commented Oct 21, 2020

cmsbuild commented Oct 21, 2020

jfernan2 commented Oct 21, 2020

perrotta commented Oct 21, 2020

christopheralanwest commented Oct 21, 2020

silviodonato commented Oct 22, 2020

Removed FwkJob category from MessageLogger config #31874

Removed FwkJob category from MessageLogger config #31874

Conversation

Dr15Jones commented Oct 20, 2020

PR description:

PR validation:

cmsbuild commented Oct 20, 2020

Dr15Jones commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

Dr15Jones commented Oct 20, 2020

cmsbuild commented Oct 20, 2020 • edited Loading

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

perrotta commented Oct 21, 2020

cmsbuild commented Oct 21, 2020 • edited Loading

cmsbuild commented Oct 21, 2020

cmsbuild commented Oct 21, 2020

cmsbuild commented Oct 21, 2020

jfernan2 commented Oct 21, 2020

perrotta commented Oct 21, 2020

christopheralanwest commented Oct 21, 2020

silviodonato commented Oct 22, 2020

cmsbuild commented Oct 20, 2020 •

edited

Loading

cmsbuild commented Oct 21, 2020 •

edited

Loading