Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pythia 8.313 #9612

Open
wants to merge 2 commits into
base: IB/CMSSW_15_0_X/master
Choose a base branch
from
Open

Pythia 8.313 #9612

wants to merge 2 commits into from

Conversation

mseidel42
Copy link
Contributor

Update to Pythia 8.313, contains

Full changelog here: https://pythia.org/latest-manual/UpdateHistory.html#section0

Needs cms-sw/cmssw#47092

@mseidel42 mseidel42 mentioned this pull request Jan 13, 2025
Open
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mseidel42 for branch IB/CMSSW_15_0_X/master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 13, 2025 •
edited
Loading

cms-bot internal usage

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#47092

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5f427/43744/summary.html
COMMIT: 4af6344
CMSSW: CMSSW_15_0_X_2025-01-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9612/43744/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5f427/43744/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5f427/43744/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

RelVals

----- Begin Fatal Exception 14-Jan-2025 02:37:25 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
   [1] Calling method for module Pythia8ConcurrentGeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 14-Jan-2025 02:30:20 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
   [1] Calling method for module Pythia8ConcurrentGeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 14-Jan-2025 02:30:34 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
   [1] Calling method for module Pythia8ConcurrentGeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

AddOn Tests

----- Begin Fatal Exception 14-Jan-2025 02:31:12 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
   [1] Calling method for module Pythia8ConcurrentGeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 14-Jan-2025 02:31:11 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
   [1] Calling method for module Pythia8ConcurrentGeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 14-Jan-2025 02:31:12 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
   [1] Calling method for module Pythia8ConcurrentGeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@mseidel42
Copy link
Contributor Author

Ok, I think there is a bug in the Pythia 8.313 PDF setup, trying to patch it

@cmsbuild
Copy link
Contributor

Pull request #9612 was updated.

@smuzaffar
Copy link
Contributor

test parameters:

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5f427/43787/summary.html
COMMIT: d3cb978
CMSSW: CMSSW_15_0_X_2025-01-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9612/43787/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5f427/43787/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5f427/43787/git-merge-result

Comparison Summary

Summary:

  • You potentially added 70 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 72764 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3817749
  • DQMHistoTests: Total failures: 467359
  • DQMHistoTests: Total nulls: 328
  • DQMHistoTests: Total successes: 3350042
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -677.2280000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.234 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 0.629 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 16834.0 ): -677.346 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 250202.181 ): -0.404 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.127 KiB SiStrip/MechanicalView
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 15 / 47 workflows

@smuzaffar
Copy link
Contributor

assign generators

@cmsbuild
Copy link
Contributor

New categories assigned: generators

@bbilin,@lviliani,@menglu21,@mkirsano you have been requested to review this Pull request/Issue and eventually sign? Thanks

@smuzaffar
Copy link
Contributor

@cms-sw/generators-l2 , can you please review this change?

@mseidel42
Copy link
Contributor Author

Hi Shahzad, GEN L2s want to discuss at an upcoming meeting whether we should keep the Pythia 8 version frozen for Run 3 or update it, so I think this is on hold for now.

Btw, Pythia bug report filed here: https://gitlab.com/Pythia8/releases/-/issues/543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending generators-pending orp-pending pending-signatures requires-external tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mseidel42 @cmsbuild @smuzaffar