Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ppd, pdmv, dqm categories #2364

Merged
merged 2 commits into from
Oct 30, 2024
Merged

update ppd, pdmv, dqm categories #2364

merged 2 commits into from
Oct 30, 2024

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented Oct 30, 2024

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vlimant for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2024 •
edited
Loading

cms-bot internal usage

@vlimant
Copy link
Contributor Author

vlimant commented Oct 30, 2024

FYI @malbouis

@vlimant
Copy link
Contributor Author

vlimant commented Oct 30, 2024

failures not related to my proposed changes

smuzaffar
smuzaffar reviewed Oct 30, 2024
View reviewed changes
categories.py
"mmasciov": ["tracking-pog"],
# PPD
"malbouis": ["ppd"],
"jordan-martins": ["ppd"],
"vlimant": ["ppd"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlimant , can you please remove this duplicate entry ( it is already there at https://github.com/cms-sw/cms-bot/blob/master/categories.py#L71 )

@smuzaffar
Copy link
Contributor

assign dqm,pdmv,ppd

Can you please approve this change?

@cmsbuild
Copy link
Contributor

New categories assigned: dqm,pdmv,ppd

@AdrianoDee,@antoniovagnerini,@jordan-martins,@kskovpen,@malbouis,@miquork,@nothingface0,@rvenditti,@sunilUIET,@syuvivida,@tjavaid,@vlimant you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

Pull request #2364 was updated.

@malbouis
Copy link
Contributor

malbouis commented Oct 30, 2024 •
edited
Loading

+1

@AdrianoDee
Copy link
Contributor

+pdmv

@smuzaffar smuzaffar merged commit bacc076 into cms-sw:master Oct 30, 2024
2 of 4 checks passed
@antoniovagnerini
Copy link

+dqm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuzaffar smuzaffar smuzaffar left review comments

Assignees
No one assigned
Labels
dqm-approved externals-pending orp-pending pdmv-approved pending-signatures ppd-approved tests-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vlimant @cmsbuild @smuzaffar @malbouis @AdrianoDee @antoniovagnerini