Run hltPhase2UpgradeIntegrationTests in IB, add option to run hlt p2 integration script for PRs
#2354
Conversation
|
A new Pull Request was created by @mmusich for branch master. @aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
run-hlt-validation
Outdated
| @@ -39,6 +39,12 @@ cd HLTrigger/Configuration/test/ | |||
| ls | |||
| ./runAll.csh IB | tee -a $WORKSPACE/results/runIB.log | |||
| ./examLogs.csh | tee -a $WORKSPACE/results/examLogs.out | |||
| which hltPhase2UpgradeIntegrationTests || true | |||
| if [ $? -eq 0 ]; then | |||
There was a problem hiding this comment.
@mmusich , I think this will always pass due to || true so $? will always be 0. You can just do
if which hltPhase2UpgradeIntegrationTests 2>/dev/null ; then
| # Upload results | ||
| source $WORKSPACE/cms-bot/jenkins-artifacts | ||
| touch ${RESULTS_DIR}/15-hlt-p2-integration-report.res ${RESULTS_DIR}/15-hlt-p2-integration-failed.res | ||
| if [ -f $WORKSPACE/rundir/Phase2Timing_resources.json ] ; then |
There was a problem hiding this comment.
@mmusich , so hltPhase2UpgradeIntegrationTests is support to generate this json file?
There was a problem hiding this comment.
yes, because we run the timing menu in test, https://github.com/cms-sw/cmssw/blob/17aa1f4d4bab45f9bbf0479f068dbf699efb8d30/HLTrigger/Configuration/scripts/hltPhase2UpgradeIntegrationTests#L113. But it's a by-product, not the main purpose.
|
Pull request #2354 was updated. |
|
+externals looks good to me. There is nothing we can test via PR tests at this time. Lets merge it so that bot can recognize the |
cmsbuild
added
fully-signed
externals-approved
and removed
pending-signatures
externals-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
@mmusich , I am setting up jenkins job to run the pr test. Any idea how long time test should run? Does it run in single thread/process mode ? Do we need any special resources or can we run it on lxplus? |
in my tests it runs in around 30-40 minutes on |
is there a way to control the parallel execution? For IBs, the HLT tests run on batch nodes ( with 8 or 16 cores). It will be waste of resources if it run 4 single threaded cmsRun jobs on 16 core node. Can we pass |
we could use the builtin option |
|
ok I have opened #2356 and started enable |
Title says it all:
hltPhase2UpgradeIntegrationTestsin IB, fe7c021I didn't really test any of this, I am particularly unsure about the second bullet, which is largely based on #2240.