Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Disable checking for number of modified files in non-cmssw repos #2323

Merged
merged 1 commit into from
Sep 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion process_pr.py
Original file line number Diff line number Diff line change
Expand Up @@ -1625,6 +1625,7 @@ def process_pr(repo_config, gh, repo, issue, dryRun, cmsbuild_user=None, force=F
pr.changed_files >= TOO_MANY_FILES_WARN_THRESHOLD
and (not warned_too_many_files)
and (not ok_too_many_files)
and cmssw_repo
):
if pr.changed_files < TOO_MANY_FILES_FAIL_THRESHOLD:
if not dryRun:
Expand All @@ -1650,7 +1651,11 @@ def process_pr(repo_config, gh, repo, issue, dryRun, cmsbuild_user=None, force=F

return

if pr.changed_files >= TOO_MANY_FILES_WARN_THRESHOLD and not ok_too_many_files:
if (
pr.changed_files >= TOO_MANY_FILES_WARN_THRESHOLD
and not ok_too_many_files
and cmssw_repo
):
print("Changed file count reached and not overridden, quitting")
return

Expand Down
Loading