Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow closing/reopening a PR even if there are too many commits or changed files #2292

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

iarspider
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 11, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor

looks good @iarspider. Although it should work but do we have any old cmssw PR with a lot of commits or files which we can use to test this change?

@smuzaffar
Copy link
Contributor

I guess we can try cms-sw/cmssw#45400

@smuzaffar
Copy link
Contributor

+externals

though it did not work for cms-sw/cmssw#45400 as the original branch has been deleted but at least bot properly tried to open the PR

@smuzaffar smuzaffar merged commit 6bcbc54 into master Jul 11, 2024
7 of 8 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the process-pr-prioritize-close branch September 2, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants