Fix CachingHostAllocator for multiple GPUs #212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CachingHostAllocator
uses an associated CUDA stream and device for "asynchronous free" (to support the creation+transfer of "me" pointer in data formatscmssw/CUDADataFormats/SiPixelDigi/src/SiPixelDigisCUDA.cc
Lines 17 to 25 in e5291a0
). The implementation missed one detail regarding multiple GPUs: when claiming a previously-cached memory block, the current device may differ from the device of the previous allocation, and in that case, the CUDA event must be re-created for the new device.
This PR fixes that behavior, and should fix the crashes reported in #208 (comment).
@fwyzard