Update VH Leptonic Tags under STXS workflow #1198
Conversation
youyingli
commented
Jan 30, 2020
youyingli
commented
- Update WH Leptonic Tag with full RunII MVA training
- VHLeptonicLooseTag is absorbed into WH Leptonic Tag
- Split WH Leptonic Tag into several reco categories according to MVA and diphoton pt
- Update ZH Leptonic Tag with cut-based selection
| rho_, evt.isRealData() ); | ||
|
|
||
| hasGoodElec = ( goodElectrons.size() > 0 ); | ||
| std::vector<edm::Ptr<Electron> >goodElectrons = selectStdElectrons( theElectrons->ptrs(), |
There was a problem hiding this comment.
From which file are you loading this? please check the issue here:
#1195
There was a problem hiding this comment.
Leptonselection.cc is applied in WH Leptonic Tag and ZH Leptonic Tag.
There was a problem hiding this comment.
Are you sure those are the recommended IDs from the respective POGs?
There was a problem hiding this comment.
In LeptonSelection.cc, WH and ZH leptonic tag use selectStdElectrons function which has cut-based loose electron ID called from MIcroAOD (like electron->passLooseId(), I think this is recommended) and photon veto, but LeptonSelection2018.cc uses electron MVA WP so I didn't use it. Maybe these two files should be merged to a single file which can choose cut-based ID or MVA WP.
|
Looks good a part for few things I pointed out line by line. Please also check with @edjtscott if the tag producers behavior is the one expected now after the recent changes (I suspect you can remove the TagTruth part). simone |
|
STXS information now has been added in TagTruth of WH and ZH leptonic Tag |
|
hi @youyingli and @simonepigazzini - the developments from this PR are now included in PR 1204 so I will close this one. |
