Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnitAI: Fix Wandering Eye of Kilrogg #718

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

insunaa
Copy link
Contributor

@insunaa insunaa commented Jan 1, 2025

🍰 Pullrequest

This PR fixes the Wandering Eye of Kilrogg, ensuring that it can start casting its summoning spell and then despawning the eye when summon has concluded.

Todo / Checklist

  • Check for consequences from moving CreatureAI::EnterCombat() behind ProcessEvents()

@killerwife
Copy link
Contributor

Also if you have the despawn thing sniffed, post the sniff here.

@insunaa
Copy link
Contributor Author

insunaa commented Jan 1, 2025

I don't have it sniffed, only "witnessed" :(

Creature* caster = static_cast<Creature*>(spell->GetCaster());
if (!caster || !caster->IsAlive() || !caster->IsCreature())
return;
caster->ForcedDespawn();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1000 ms delay, make mob passive and set combat script to true cos its not reacting in that 1 sec delay

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From sniff btw

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants