Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint for updating user info #1206

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Conversation

GalMunGral
Copy link
Collaborator

No description provided.

@GalMunGral GalMunGral marked this pull request as ready for review November 7, 2024 15:22
Copy link
Member

@lmarini lmarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GalMunGral @max-zilla this works great. I could even change the email and log in with the new email address. Unfortuantely, most of our queries that filter on current user use email and the old email is on the existing resources, resulting in things like listing my datasets not working anymore. For now can we disable changing the email address? We can address the queries later and reanable it then. How does that sound? Thanks!

@GalMunGral
Copy link
Collaborator Author

@GalMunGral @max-zilla this works great. I could even change the email and log in with the new email address. Unfortuantely, most of our queries that filter on current user use email and the old email is on the existing resources, resulting in things like listing my datasets not working anymore. For now can we disable changing the email address? We can address the queries later and reanable it then. How does that sound? Thanks!

Sounds good! I'll update the code

@GalMunGral GalMunGral requested a review from lmarini November 8, 2024 21:19
@lmarini lmarini merged commit 96a61d1 into release/v2.0-beta-3 Nov 11, 2024
6 checks passed
@lmarini lmarini deleted the feature/update-user branch November 11, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants