fix: deep copy nil string (#1562)

cloudwego · Nov 13, 2024 · 9685fc2 · 9685fc2
1 parent f66a3a7
commit 9685fc2
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/tool/internal_pkg/pluginmode/thriftgo/struct_tpl.go b/tool/internal_pkg/pluginmode/thriftgo/struct_tpl.go
@@ -713,16 +713,17 @@ const FieldDeepCopyBaseType = `
 	{{- if .IsPointer}}
 		if {{$Src}} != nil {
 			{{- if IsGoStringType .TypeName}}
+			var tmp string
 			if *{{$Src}} != "" {
-				tmp := kutils.StringDeepCopy(*{{$Src}})
-				{{.Target}} = &tmp
+				tmp = kutils.StringDeepCopy(*{{$Src}})
 			}
+			{{.Target}} = &tmp
 			{{- else if .Type.Category.IsBinary}}
+			tmp := make([]byte, len(*{{$Src}}))
 			if len(*{{$Src}}) != 0 {
-				tmp := make([]byte, len(*{{$Src}}))
 				copy(tmp, *{{$Src}})
-				{{.Target}} = &tmp
 			}
+			{{.Target}} = &tmp
 			{{- else}}
 			tmp := *{{$Src}}
 			{{.Target}} = &tmp