Features for Hub #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkitCLI
force-pushed
the
e2e-hub-tests
branch
3 times, most recently
from
8f64ebc
to
a8f4a4a
Compare
| Feature: Hub - Run time scenarios | ||
|
|
||
| @TS-HUB-RNTM-01 | ||
| Scenario: Verify that the user is able to deploy and delete a plugin |
There was a problem hiding this comment.
Change it to 'Verify that the user is able to deploy a plugin in Hub and then delete it successfully .
| @RunWith(Cucumber.class) | ||
| @CucumberOptions( | ||
| features = {"src/e2e-test/features"}, | ||
| glue = {}, |
There was a problem hiding this comment.
Why we have not added glue "io.cdap.cdap.hub.stepsdesign", "stepsdesign"
There was a problem hiding this comment.
we have not added because in these phase 1 features we are not using any hooks and stepdesigns so far.So it is not necessary as of now.We will use it in phase 2 features.
itsmekumari
reviewed
Oct 26, 2023
| @@ -3,3 +3,8 @@ clientUrl=http://localhost:11011 | |||
| serverUrl=https://placeholder.com/api | |||
| # command to generate token: gcloud auth print-access-token | |||
| serverAccessToken=placeholder | |||
| expectedPluginName=Anaplan | |||
There was a problem hiding this comment.
And the start and end comments section for HUB related properties as this is common file. Refer google cloud repo for same.
AnkitCLI
force-pushed
the
e2e-hub-tests
branch
2 times, most recently
from
5ad4911
to
a178c75
Compare
itsmekumari
approved these changes
Oct 27, 2023
AnkitCLI
force-pushed
the
e2e-hub-tests
branch
3 times, most recently
from
8609788
to
2d0c172
Compare
rahuldash171
approved these changes
Oct 27, 2023
AnkitCLI
force-pushed
the
e2e-hub-tests
branch
from
2d0c172
to
4fb9a31
Compare
AnkitCLI
force-pushed
the
e2e-hub-tests
branch
from
4fb9a31
to
5457eec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.