control center framework steps phase2 #19

priyabhatnagar25 · 2023-11-20T09:41:12Z

No description provided.

itsmekumari · 2023-11-20T13:09:03Z

src/main/java/io/cdap/e2e/pages/actions/CdfControlCenterActions.java

+    ElementHelper.isElementDisplayed(CdfControlCenterLocators.pipelineDeletedMessage);
+  }
+
+  public static void clickOnSearchTabControlCenter(String message) {


Add the comments on each action. Please check the existing pipeline actions for reference.

added all the comments

itsmekumari · 2023-11-20T13:11:07Z

src/main/java/io/cdap/e2e/pages/actions/CdfControlCenterActions.java

+  }
+
+  /**
+   * Clicks on the Schema Tab.


Change to Click

itsmekumari · 2023-11-20T13:11:46Z

src/main/java/io/cdap/e2e/pages/actions/CdfControlCenterActions.java

+  }
+
+  /**
+   * Checks for the displayed Schema page.


Change to Check, remove 's' in all comments

changed in all comments

itsmekumari · 2023-11-20T13:22:46Z

src/main/java/stepsdesign/ControlCenterSteps.java

+    CdfControlCenterActions.clickOnSearchTagControlCenter(value);
+  }
+
+  @Then("Verify user can see the searched tag successfully on the control center page")


Verify the searched tag is displayed successfully on control center page

Hi Priya , We tried looking for the changed line provided by Surya but it is not seen in any of thecdap repo feature files . If it is not changed there then how the scenario will work ?

itsmekumari · 2023-11-20T13:25:54Z

src/main/java/stepsdesign/ControlCenterSteps.java

+  public void tagCountIncreasesDataset() {
+    CdfControlCenterActions.tagCountIncreasesDataset(); }
+
+  @Then("Click on the close icon of the added tag and verify that the tag count decreases")


Click on the close icon of tag added and verify the tag count decreases

itsmekumari · 2023-11-20T13:26:53Z

src/main/java/stepsdesign/ControlCenterSteps.java

+    CdfControlCenterActions.pressEnterKey();
+  }
+
+  @Then("Verify that the tag count of dataset entity increases when the user adds the tag")


Verify the tag count of dataset entity when user adds the tag

itsmekumari · 2023-11-20T13:29:14Z

src/main/java/stepsdesign/ControlCenterSteps.java

+  public void clickOnAToZOptionMessage() {
+    CdfControlCenterActions.clickOnAToZOptionMessage(); }
+
+  @Then("Click on the plus add button of the dataset entity to add the tags successfully")


Click on the plus button to add the tag for a dataset entity

itsmekumari · 2023-11-20T13:32:38Z

src/main/java/stepsdesign/ControlCenterSteps.java

+  public void selectDropdownFilterOptionValue(String pluginProperty, String option) {
+    CdfControlCenterActions.selectFilterDropdownOption(pluginProperty, option); }
+
+  @Then("Verify user is able to see all entities displayed message on the basis of filter selection")


Verify the all entities message is displayed with the filter selection

itsmekumari · 2023-11-20T13:34:47Z

src/main/java/stepsdesign/ControlCenterSteps.java

+  public void clickBackTabDatasetEntity() {
+    CdfControlCenterActions.clickOnBackTabDatasetEntity(); }
+
+  @Then("Click on the close link of the view details page of dataset entity to close the details page")


Click on close link to close the details page of dataset entity

itsmekumari · 2023-11-20T13:35:51Z

src/main/java/stepsdesign/ControlCenterSteps.java

+  public void truncateDatasetEntity() {
+    CdfControlCenterActions.clickOnTruncateDatasetEntity(); }
+
+  @Then("Click on the view details tab of dataset entity page to see the details page of the dataset")


Click on view details tab of dataset entity

itsmekumari · 2023-11-20T13:39:44Z

src/main/java/stepsdesign/ControlCenterSteps.java

+    CdfControlCenterActions.deletedDatasetNotPresent(value);
+  }
+
+  @Then("Click on the truncate icon of the dataset entity and the dataset should get truncated successfully")


Click truncate and verify the successful truncate of dataset entity

itsmekumari · 2023-11-20T13:40:41Z

src/main/java/stepsdesign/ControlCenterSteps.java

+    CdfControlCenterActions.navigateDetailsPageDatasetEntity();
+  }
+
+  @Then("Click on the delete icon of the dataset entity and the dataset should get deleted successfully")


Click delete and verify the dataset is deleted successfully

itsmekumari · 2023-11-20T13:46:06Z

src/main/java/stepsdesign/ControlCenterSteps.java

+  public void clickOnDeleteIconSetPreferences() {
+    CdfControlCenterActions.clickOnDeleteIconSetPreferences(); }
+
+  @Then("Verify user is able to click on the dataset entity icon to see the details page of the dataset")


Verify the user is able to click dataset entity icon to navigate to details page

itsmekumari · 2023-11-20T13:57:49Z

src/main/java/stepsdesign/ControlCenterSteps.java

+    CdfControlCenterActions.navigateToControlCenter();
+  }
+
+  @Then("Verify user is able to click on the create button to create a pipeline successfully")


Change -- 'Click on create button to create a pipeline'.

rahuldash171 · 2023-11-20T13:13:38Z

src/main/java/io/cdap/e2e/pages/locators/CdfControlCenterLocators.java

+  }
+
+  @FindBy(how = How.XPATH, using = "//button[@data-cy='save-prefs-btn']")
+  public static WebElement clickSaveAndCloseButton;


remove click and only write saveAndCloseButton

change it wherever there is click for locators

rahuldash171 · 2023-11-20T13:14:16Z

src/main/java/io/cdap/e2e/pages/locators/CdfControlCenterLocators.java

+  public static WebElement clickOnDatasetDeleteIcon;
+
+  @FindBy(how = How.XPATH, using = "(//*[@class='icon-svg icon-cut'])[1]")
+  public static WebElement clickOnTruncateDatasetEntity;


remove click from all locators name because click is a action not a element

rahuldash171 · 2023-11-20T13:15:13Z

src/main/java/stepsdesign/ControlCenterSteps.java

+    CdfControlCenterActions.clickOnSearchTagControlCenter(value);
+  }
+
+  @Then("Verify user can see the searched tag successfully on the control center page")


Change to ' Verify if user sees the searched tag succesfully in control center'

rahuldash171 · 2023-11-20T13:28:56Z

src/main/java/stepsdesign/ControlCenterSteps.java

+
+  @Then("Verify user is navigated to the details page of the dataset entity icon successfully")
+  public void navigateDetailsPageDatasetEntity() {
+


remove space here

rahuldash171 · 2023-11-20T13:30:45Z

src/main/java/stepsdesign/ControlCenterSteps.java

+
+  @Then("Verify the user is able to set the preferences for the created pipeline in the control center page")
+  public void setPreferencesForPipeline() {
+    CdfControlCenterActions.clickOnSetPreferencesIcon(); }


use formatting and check wheather } should be added in new line

rahuldash171 · 2023-11-20T13:36:03Z

src/main/java/io/cdap/e2e/pages/locators/CdfControlCenterLocators.java

+  public static WebElement clickOnCloseTagIconDatasetEntity;
+
+  @FindBy(how = How.XPATH, using = "//i[normalize-space()='No tags found. Click to add a new business tag.']")
+  public static WebElement tagCounDecreasetIconDatasetEntity;


why this name for the locator . we are just seeing a message in this locator , change it to defaultTagCountMessageDataset or something like that

we are removing the tag , here so we are writing decreease intially it was one and then removing the added

Changed the locator name and included the word message

rahuldash171 · 2023-11-20T13:45:50Z

src/main/java/io/cdap/e2e/pages/locators/CdfControlCenterLocators.java

+  }
+
+  public static By clickOnTruncateButton() {
+    return By.xpath("//button[@class='btn btn-primary'][//button[@data-cy='Truncate']]");


change it to //div//button[@data-cy='Truncate']

rahuldash171 · 2023-11-20T13:48:13Z

src/main/java/io/cdap/e2e/pages/locators/CdfControlCenterLocators.java

+  public static WebElement createButtonControlCenter;
+
+  @FindBy(how = How.XPATH, using = "//span[@class='entity-type'][//span[contains(text(),'Data Pipeline')]]")
+  public static WebElement dataPipelineControlCenter;


change to //span[contains(text(),'Data Pipeline')]

this we are checking for the added pipeline in the contol center thats why for more clearance i used class also here.

itsmekumari · 2023-11-22T11:01:38Z

src/main/java/stepsdesign/ControlCenterSteps.java

+    CdfControlCenterActions.selectSortDropdownOptionValue(option);
+  }
+
+  @Then("Verify user is able to see the entities sorted by the newest option")


Change - Verify the entities are sorted by the newest option

itsmekumari · 2023-11-22T11:03:13Z

src/main/java/stepsdesign/ControlCenterSteps.java

+    CdfControlCenterActions.clickOnNewestOptionMessage();
+  }
+
+  @Then("Verify user is able to see the entities sorted by the oldest option")


Change - Verify the entities are sorted by the oldest option

itsmekumari · 2023-11-22T11:03:34Z

src/main/java/stepsdesign/ControlCenterSteps.java

+    CdfControlCenterActions.clickOnOldestOptionMessage();
+  }
+
+  @Then("Verify user is able to see the entities sorted by the Z to A option")


Change - Verify the entities are sorted by the Z to A option

itsmekumari · 2023-11-22T11:04:03Z

src/main/java/stepsdesign/ControlCenterSteps.java

+    CdfControlCenterActions.clickOnZToAOptionMessage();
+  }
+
+  @Then("Verify user is able to see the entities sorted by the A to Z option")


Change - Verify the entities are sorted by the A to Z option

itsmekumari reviewed Nov 20, 2023

View reviewed changes

rahuldash171 reviewed Nov 20, 2023

View reviewed changes

itsmekumari reviewed Nov 22, 2023

View reviewed changes

priyabhatnagar25 force-pushed the e2e_controlcenter_tests_2 branch 2 times, most recently from b9eabdf to 1c08384 Compare November 29, 2023 12:34

priyabhatnagar25 added 2 commits January 22, 2024 14:04

control center framework steps phase2

830e420

control center framework review comments

c63b278

priyabhatnagar25 force-pushed the e2e_controlcenter_tests_2 branch from 6504d54 to c63b278 Compare January 22, 2024 08:35


		@Then("Verify user is navigated to the details page of the dataset entity icon successfully")
		public void navigateDetailsPageDatasetEntity() {

control center framework steps phase2 #19

Are you sure you want to change the base?

control center framework steps phase2 #19

Conversation

priyabhatnagar25 commented Nov 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment