new sysadmin locators, actions and steps definition #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param requestMethod any specific value | ||
| */ | ||
| public static void selectRequestDropdownOption(String requestMethod) { | ||
| Select objSelect = new Select(CdfSysAdminLocators.requestMethod); |
There was a problem hiding this comment.
Can we change objSelect to selectRequestMethod
There was a problem hiding this comment.
Changed to selectRequestMethod
| @@ -51,4 +53,47 @@ public class CdfSysAdminLocators { | |||
|
|
|||
| @FindBy(how = How.XPATH, using = "//*[@data-cy='Clear All']") | |||
| public static WebElement clearAll; | |||
|
|
|||
| @FindBy(how = How.XPATH, using = "//*[@data-cy='wizard-result-icon-close-btn']") | |||
| public static WebElement clickOnCloseNamespaceWindow; | |||
There was a problem hiding this comment.
Can we remove using click while defining locators , click/sendKeys are user functions which we can use in methods but not in while declaring locators . the naming should be like CloseNamespaceWindowButton .
There was a problem hiding this comment.
Change done in final PR and in this as well.
| @FindBy(how = How.XPATH, using = "//a[contains(text(), 'Go to homepage')]") | ||
| public static WebElement goToHomepage; | ||
|
|
||
| @FindBy(how = How.XPATH, using = "//a[@href='/cdap/httpexecutor']") //remove later |
There was a problem hiding this comment.
remove this comment in final code Or specify a proper comment
There was a problem hiding this comment.
Removed here and also In Final PR code while merging this is removed.
rahuldash171
approved these changes
Oct 31, 2023
Vipinofficial11
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new sysadmin locators, actions and steps definition