Skip to content

Commit

Permalink
Addressed review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
rahuldash171 committed Nov 28, 2023
1 parent e15edd7 commit 86c646f
Showing 1 changed file with 14 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -102,23 +102,23 @@ public static void selectHamburgerMenuList(String listName) {
* keyValuePair as key
*/
public static void enterKeyValuePreferences(String preferenceProperty, String keyValuePair) {
String pluginPropertyDataCyAttribute = PluginPropertyUtils.getPluginPropertyDataCyAttribute(
String dataCyAttribute = PluginPropertyUtils.getPluginPropertyDataCyAttribute(
preferenceProperty);
if (pluginPropertyDataCyAttribute == null) {
pluginPropertyDataCyAttribute = preferenceProperty;
if (dataCyAttribute == null) {
dataCyAttribute = preferenceProperty;
}
Map<String, String> properties =
JsonUtils.convertKeyValueJsonArrayToMap(PluginPropertyUtils.pluginProp(keyValuePair));
int index = 0;
for (Map.Entry<String, String> entry : properties.entrySet()) {
if (index != 0) {
ElementHelper.clickOnElement(CdfNameSpaceAdminLocators.locateAddRowButtonProperty(
pluginPropertyDataCyAttribute, index - 1));
dataCyAttribute, index - 1));
}
ElementHelper.sendKeys(CdfNameSpaceAdminLocators.locateKeyProperty(
pluginPropertyDataCyAttribute, index), entry.getKey());
dataCyAttribute, index), entry.getKey());
ElementHelper.sendKeys(CdfNameSpaceAdminLocators.locateValueProperty(
pluginPropertyDataCyAttribute, index), entry.getValue());
dataCyAttribute, index), entry.getValue());
index++;
}
}
Expand All @@ -131,13 +131,13 @@ public static void enterKeyValuePreferences(String preferenceProperty, String ke
* fetched from it else Provisioner is used as it is.
*/
public static void selectProvisioner(String provisionerName) {
String pluginPropertyDataCyAttribute = PluginPropertyUtils.getPluginPropertyDataCyAttribute(
String dataCyAttribute = PluginPropertyUtils.getPluginPropertyDataCyAttribute(
provisionerName);
if (pluginPropertyDataCyAttribute == null) {
pluginPropertyDataCyAttribute = provisionerName;
if (dataCyAttribute == null) {
dataCyAttribute = provisionerName;
}
ElementHelper.clickOnElement(
CdfNameSpaceAdminLocators.locateProvisionerInList(pluginPropertyDataCyAttribute));
CdfNameSpaceAdminLocators.locateProvisionerInList(dataCyAttribute));
}

/**
Expand Down Expand Up @@ -180,13 +180,13 @@ public static void verifyIfResetValidatedSuccessfully() {
* fetched from it else type of action is used as it is.
*/
public static void clickCreateButtonComputeProfile(String buttonType) {
String pluginPropertyDataCyAttribute = PluginPropertyUtils.getPluginPropertyDataCyAttribute(
String dataCyAttribute = PluginPropertyUtils.getPluginPropertyDataCyAttribute(
buttonType);
if (pluginPropertyDataCyAttribute == null) {
pluginPropertyDataCyAttribute = buttonType;
if (dataCyAttribute == null) {
dataCyAttribute = buttonType;
}
ElementHelper.clickOnElement(
CdfNameSpaceAdminLocators.locateButtonType(pluginPropertyDataCyAttribute));
CdfNameSpaceAdminLocators.locateButtonType(dataCyAttribute));
}

/**
Expand Down

0 comments on commit 86c646f

Please sign in to comment.