Amazon S3 Batch Source Plugin: Add validation for incorrect credentials #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| s3.listBuckets(); | ||
| } catch (AmazonS3Exception exception) { | ||
| collector.addFailure(String.format("Invalid credentials: %s.", exception.getMessage()), | ||
| "Please provide valid credentials.").withStacktrace(exception.getStackTrace()); |
There was a problem hiding this comment.
is it a common practice to add stackTrace in failureCollectors or adding stackTrace will only show in logs and not in UI.
There was a problem hiding this comment.
Yes, Albert suggested including the stack trace to the failure collector in order to show the detailed error message on the UI.
sgarg-CS
force-pushed
the
validation-fix
branch
from
b232cf0
to
0183eb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.