Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Render drawers bar if only global drawers are present #3006

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

just-boris
Copy link
Member

Description

When only global drawers are present, the panel still should render

Related links, issue #, if available: AWSUI-59981

How has this been tested?

Locally. More tests later

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (31cd27d) to head (01a925d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3006    +/-   ##
========================================
  Coverage   96.30%   96.30%            
========================================
  Files         777      777            
  Lines       21874    21881     +7     
  Branches     7470     7074   -396     
========================================
+ Hits        21066    21073     +7     
- Misses        755      800    +45     
+ Partials       53        8    -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

georgylobko
georgylobko previously approved these changes Nov 13, 2024
@georgylobko georgylobko marked this pull request as ready for review November 13, 2024 14:36
@georgylobko georgylobko requested a review from a team as a code owner November 13, 2024 14:36
@georgylobko georgylobko requested review from dpitcock and removed request for a team November 13, 2024 14:36
Copy link
Member Author

@just-boris just-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot approve my own PR, but feel free to merge this, all good by me

@georgylobko georgylobko added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit a89976c Nov 13, 2024
38 checks passed
@georgylobko georgylobko deleted the fix-global-drawers branch November 13, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants