Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Separate mobile and desktop tests for recent scroll fix #2992

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

jkuelz
Copy link
Member

@jkuelz jkuelz commented Nov 7, 2024

Description

For more reliable test coverage, this separates mobile and desktop scroll tests for #2987 fix.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jkuelz jkuelz requested a review from a team as a code owner November 7, 2024 17:45
@jkuelz jkuelz requested review from abdhalees and georgylobko and removed request for a team November 7, 2024 17:45
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (054f1c9) to head (177f68f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2992    +/-   ##
========================================
  Coverage   96.27%   96.27%            
========================================
  Files         769      769            
  Lines       21764    21764            
  Branches     7438     7038   -400     
========================================
  Hits        20954    20954            
  Misses        802      802            
  Partials        8        8            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkuelz jkuelz added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 62f01ce Nov 7, 2024
38 checks passed
@jkuelz jkuelz deleted the jkuelz-global-drawer-test-fix branch November 7, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants