Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow more drawer properties to be updated in the runtime API #2979

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

just-boris
Copy link
Member

Description

Make this work: awsuiPlugins.appLayout.updateDrawer({ id: 'my-drawer', defaultActive: true })

Use-case – teams want to remember the current active state, so their drawer reopens when re-mounting.

Also made orderPriority and onResize updatable as well. Not needed by the current use-case, but looks future proof

Related links, issue #, if available: n/a

How has this been tested?

Added an extra unit test

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (9ab7368) to head (b03c46c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2979      +/-   ##
==========================================
- Coverage   96.30%   96.30%   -0.01%     
==========================================
  Files         777      777              
  Lines       21878    21874       -4     
  Branches     7481     7068     -413     
==========================================
- Hits        21070    21066       -4     
- Misses        755      800      +45     
+ Partials       53        8      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	pages/app-layout/utils/content-blocks.tsx
#	pages/app-layout/utils/external-widget.tsx
@georgylobko georgylobko marked this pull request as ready for review November 14, 2024 16:01
@georgylobko georgylobko requested a review from a team as a code owner November 14, 2024 16:01
@georgylobko georgylobko requested review from abdhalees and removed request for a team November 14, 2024 16:01
@georgylobko georgylobko added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit f8fb30c Nov 14, 2024
38 checks passed
@georgylobko georgylobko deleted the drawer-update-states branch November 14, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants