Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support previous breadcrumbs versions in deduplication #2935

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

just-boris
Copy link
Member

@just-boris just-boris commented Oct 24, 2024

Description

Support combination "new app layout (widget)" + "old breadcrumbs (not widget)" for this change #2895

We do not know if the breadcrumb is going to globalize or not. To support both use-cases we render both own and discovered breadcrumb and then hide the globalized one with CSS

Related links, issue #, if available: n/a

How has this been tested?

  • Tested in my dev pipeline for multi-version use-case
  • Added a unit test on the new runtime API
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (3914399) to head (a3672c6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2935      +/-   ##
==========================================
- Coverage   96.24%   96.24%   -0.01%     
==========================================
  Files         767      767              
  Lines       21709    21708       -1     
  Branches     7427     7027     -400     
==========================================
- Hits        20894    20893       -1     
- Misses        762      807      +45     
+ Partials       53        8      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris marked this pull request as ready for review October 25, 2024 14:18
@just-boris just-boris requested a review from a team as a code owner October 25, 2024 14:18
@just-boris just-boris requested review from michaeldowseza and removed request for a team October 25, 2024 14:18
@just-boris just-boris added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 7cd7cc6 Oct 25, 2024
38 checks passed
@just-boris just-boris deleted the fix-global-breadcrumbs branch October 25, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants