fix: Flashbar shadow z-index issue and pages background #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2885 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 761 761
Lines 21502 21502
Branches 7354 7354
=======================================
Hits 20688 20688
Misses 806 806
Partials 8 8 ☔ View full report in Codecov by Sentry. |
orangevolon
force-pushed
the
fix/flashbar-z-index-issue-and-pages-background
branch
from
7775171
to
172f8ff
Compare
orangevolon
force-pushed
the
fix/flashbar-z-index-issue-and-pages-background
branch
from
172f8ff
to
1dd11c2
Compare
orangevolon
changed the title
orangevolon
changed the title
orangevolon
changed the title
orangevolon
requested review from
avinashbot and
just-boris
and removed request for
a team and
avinashbot
just-boris
reviewed
Oct 18, 2024
pages/app/components/page-view.tsx
Outdated
| @@ -15,7 +17,9 @@ export default function PageView({ pageId }: { pageId: string }) { | |||
| return ( | |||
| <ErrorBoundary key={pageId}> | |||
| <Suspense fallback={<span>Loading...</span>}> | |||
| <Page /> | |||
| <div className={styles['page-container']}> | |||
There was a problem hiding this comment.
Do we really need this wrapper? Can we apply the same style to the <div id="app"> that we have already?
There was a problem hiding this comment.
Great suggestion, applied the change 👍
orangevolon
force-pushed
the
fix/flashbar-z-index-issue-and-pages-background
branch
from
1dd11c2
to
7151e3d
Compare
orangevolon
force-pushed
the
fix/flashbar-z-index-issue-and-pages-background
branch
from
7151e3d
to
3a649b9
Compare
avinashbot
approved these changes
Oct 18, 2024
just-boris
approved these changes
Oct 18, 2024
orangevolon
deleted the
fix/flashbar-z-index-issue-and-pages-background
branch
dpitcock
pushed a commit
that referenced
this pull request
Oct 23, 2024
timogasda
pushed a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reopens #2813 and #2767 after being reverted at #2876, with the following fix:
Flashbar items use
box-shadowon the element itself rather than the pseudo element withz-index: -1.Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.