chore: Add initialCheck capability to alert/flash content API
#2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2879 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 761 761
Lines 21490 21511 +21
Branches 7359 7357 -2
=======================================
+ Hits 20676 20697 +21
Misses 761 761
Partials 53 53 ☔ View full report in Codecov by Sentry. |
gethinwebster
force-pushed
the
iam-plugin-refactoring
branch
from
6700440
to
be9ecb4
Compare
gethinwebster
requested review from
georgylobko
and removed request for
a team
georgylobko
previously approved these changes
Oct 18, 2024
georgylobko
approved these changes
Oct 18, 2024
just-boris
reviewed
Oct 18, 2024
| @@ -77,6 +77,7 @@ | |||
| "@types/react-resizable": "^1.7.4", | |||
| "@types/react-router": "^5.1.18", | |||
| "@types/react-router-dom": "^5.3.2", | |||
| "@types/react-test-renderer": "^18.3.0", | |||
There was a problem hiding this comment.
The types version does not match the actual version of the dependency
dpitcock
pushed a commit
that referenced
this pull request
Oct 23, 2024
timogasda
pushed a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add capability to conditionally hide the initial render of alerts and flashes. This reduces the layout shift
that occurs when the alert/flash content is then replaced via runtime API.
Related links, issue #, if available: n/a
How has this been tested?
New unit tests.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.