Skip to content

feat: Add scroll snapping to responsive tabs #10252

feat: Add scroll snapping to responsive tabs

feat: Add scroll snapping to responsive tabs #10252

Triggered via pull request October 18, 2024 11:06
Status Failure
Total duration 17m 47s
Artifacts 2

dry-run.yml

on: pull_request
dry-run  /  Build browser-test-tools
1m 33s
dry-run / Build browser-test-tools
dry-run  /  Build documenter
1m 0s
dry-run / Build documenter
dry-run  /  Build global-styles
17s
dry-run / Build global-styles
dry-run  /  Build build-tools
14s
dry-run / Build build-tools
dry-run  /  Build collection-hooks
28s
dry-run / Build collection-hooks
dry-run  /  Build jest-preset
20s
dry-run / Build jest-preset
dry-run  /  Build component-toolkit
52s
dry-run / Build component-toolkit
dry-run  /  Build test-utils
35s
dry-run / Build test-utils
dry-run  /  Build theming-core
38s
dry-run / Build theming-core
dry-run  /  Build components
3m 23s
dry-run / Build components
dry-run  /  Build board components
2m 4s
dry-run / Build board components
dry-run  /  Build code view components
1m 2s
dry-run / Build code view components
dry-run  /  Build chat components
1m 8s
dry-run / Build chat components
Matrix: dry-run / Components accessibility tests shard
Matrix: dry-run / Components integration tests shard
dry-run  /  Components unit tests
3m 58s
dry-run / Components unit tests
dry-run  /  Components motion tests
1m 17s
dry-run / Components motion tests
dry-run  /  Components accessibility tests
0s
dry-run / Components accessibility tests
dry-run  /  Components integration tests
0s
dry-run / Components integration tests
Fit to window
Zoom out
Zoom in

Annotations

12 errors and 68 warnings
keeps selected tab in view upon width change: src/tabs/__integ__/tabs.test.ts#L111
expect(received).toEqual(expected) // deep equality Expected: 769 Received: 1 at src/tabs/__integ__/tabs.test.ts:111:54 at RetryOperation._fn (node_modules/p-retry/index.js:50:12)
does not scroll when using arrows: src/tabs/__integ__/tabs.test.ts#L133
expect(received).resolves.toBe(expected) // Object.is equality Expected: 0 Received: 1 at Object.toBe (node_modules/expect/build/index.js:174:22) at src/tabs/__integ__/tabs.test.ts:133:49 at src/tabs/__integ__/tabs.test.ts:77:5 at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
left/right arrow should have aria-disabled when first/last tab is selected: src/tabs/__integ__/tabs.test.ts#L142
expect(received).resolves.toBe(expected) // Object.is equality Expected: false Received: true at Object.toBe (node_modules/expect/build/index.js:174:22) at src/tabs/__integ__/tabs.test.ts:142:81 at src/tabs/__integ__/tabs.test.ts:77:5 at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
scrolls when clicking on left/right pagination buttons: src/tabs/__integ__/tabs.test.ts#L160
expect(received).resolves.toBe(expected) // Object.is equality Expected: false Received: true at Object.toBe (node_modules/expect/build/index.js:174:22) at src/tabs/__integ__/tabs.test.ts:160:82 at src/tabs/__integ__/tabs.test.ts:77:5 at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
scrolls when using the left/right pagination buttons with the keyboard: src/tabs/__integ__/tabs.test.ts#L175
expect(received).resolves.toBe(expected) // Object.is equality Expected: false Received: true at Object.toBe (node_modules/expect/build/index.js:174:22) at src/tabs/__integ__/tabs.test.ts:175:82 at src/tabs/__integ__/tabs.test.ts:77:5 at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
scrolls when pressing pageUp/pageDown: src/tabs/__integ__/tabs.test.ts#L192
expect(received).resolves.toBe(expected) // Object.is equality Expected: false Received: true at Object.toBe (node_modules/expect/build/index.js:174:22) at src/tabs/__integ__/tabs.test.ts:192:82 at src/tabs/__integ__/tabs.test.ts:77:5 at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
adds pagination buttons upon changing the tabs array: src/tabs/__integ__/tabs.test.ts#L44
expect(received).resolves.toBe(expected) // Object.is equality Expected: false Received: true at Object.toBe (node_modules/expect/build/index.js:174:22) at TabsPage.hasPaginationButtons (src/tabs/__integ__/tabs.test.ts:44:75) at src/tabs/__integ__/tabs.test.ts:203:16 at src/tabs/__integ__/tabs.test.ts:77:5 at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
scrolls active tab into view upon changing the tabs array: src/tabs/__integ__/tabs.test.ts#L216
expect(received).resolves.toBe(expected) // Object.is equality Expected: 0 Received: 238 at Object.toBe (node_modules/expect/build/index.js:174:22) at src/tabs/__integ__/tabs.test.ts:216:77 at RetryOperation._fn (node_modules/p-retry/index.js:50:18) at Timeout._onTimeout (node_modules/retry/lib/retry_operation.js:85:10)
allows to click on dynamically added tabs: src/tabs/__integ__/tabs.test.ts#L228
expect(received).toBe(expected) // Object.is equality Expected: false Received: true at src/tabs/__integ__/tabs.test.ts:228:75 at RetryOperation._fn (node_modules/p-retry/index.js:50:12)
does not scroll on click if not needed: src/tabs/__integ__/tabs.test.ts#L237
expect(received).resolves.toBe(expected) // Object.is equality Expected: 0 Received: 1 at Object.toBe (node_modules/expect/build/index.js:174:22) at src/tabs/__integ__/tabs.test.ts:237:49 at src/tabs/__integ__/tabs.test.ts:77:5 at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
dry-run / Components integration tests shard (2)
The job was canceled because "_1" failed.
dry-run / Components integration tests shard (2)
The operation was canceled.
dry-run / Build build-tools
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Build global-styles
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Build jest-preset
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Build collection-hooks
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Build documenter
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Build browser-test-tools
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Build test-utils
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Build component-toolkit
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Build theming-core
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Build components
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Components accessibility tests shard (1)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Build code view components
Prop "id" is forbidden on Components
dry-run / Build code view components
Prop "className" is forbidden on Components
dry-run / Build code view components
Unexpected any. Specify a different type
dry-run / Build code view components
Unexpected any. Specify a different type
dry-run / Build code view components
Unexpected any. Specify a different type
dry-run / Build code view components
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/download-artifact@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Components accessibility tests shard (4)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Build chat components
Prop "id" is forbidden on Components
dry-run / Build chat components
Prop "id" is forbidden on Components
dry-run / Build chat components
Prop "id" is forbidden on Components
dry-run / Build chat components
Prop "id" is forbidden on Components
dry-run / Build chat components
Prop "className" is forbidden on Components
dry-run / Build chat components
Unexpected any. Specify a different type
dry-run / Build chat components
Unexpected any. Specify a different type
dry-run / Build chat components
Unexpected any. Specify a different type
dry-run / Build chat components
Unexpected any. Specify a different type
dry-run / Build chat components
Unexpected any. Specify a different type
dry-run / Components motion tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Build board components
Unexpected any. Specify a different type
dry-run / Build board components
Unexpected any. Specify a different type
dry-run / Build board components
Unexpected any. Specify a different type
dry-run / Build board components
Run autofix to sort these imports!
dry-run / Build board components
Run autofix to sort these imports!
dry-run / Build board components
Run autofix to sort these imports!
dry-run / Build board components
Run autofix to sort these imports!
dry-run / Build board components
Run autofix to sort these imports!
dry-run / Build board components
Prop "id" is forbidden on Components
dry-run / Build board components
Prop "className" is forbidden on Components
dry-run / Components unit tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Components integration tests shard (4)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Components integration tests shard (3)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Components accessibility tests shard (3)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Components accessibility tests shard (6)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Components accessibility tests shard (5)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Components integration tests shard (1)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
RETRY 1: keeps selected tab in view upon width change: src/tabs/__integ__/tabs.test.ts#L111
expect(received).toEqual(expected) // deep equality Expected: 769 Received: 1 at src/tabs/__integ__/tabs.test.ts:111:54 at RetryOperation._fn (node_modules/p-retry/index.js:50:12)
RETRY 2: keeps selected tab in view upon width change: src/tabs/__integ__/tabs.test.ts#L111
expect(received).toEqual(expected) // deep equality Expected: 769 Received: 1 at src/tabs/__integ__/tabs.test.ts:111:54 at RetryOperation._fn (node_modules/p-retry/index.js:50:12)
RETRY 3: keeps selected tab in view upon width change: src/tabs/__integ__/tabs.test.ts#L111
expect(received).toEqual(expected) // deep equality Expected: 769 Received: 1 at src/tabs/__integ__/tabs.test.ts:111:54 at RetryOperation._fn (node_modules/p-retry/index.js:50:12)
RETRY 1: does not scroll when using arrows: src/tabs/__integ__/tabs.test.ts#L133
expect(received).resolves.toBe(expected) // Object.is equality Expected: 0 Received: 1 at Object.toBe (node_modules/expect/build/index.js:174:22) at src/tabs/__integ__/tabs.test.ts:133:49 at src/tabs/__integ__/tabs.test.ts:77:5 at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
RETRY 2: does not scroll when using arrows: src/tabs/__integ__/tabs.test.ts#L133
expect(received).resolves.toBe(expected) // Object.is equality Expected: 0 Received: 1 at Object.toBe (node_modules/expect/build/index.js:174:22) at src/tabs/__integ__/tabs.test.ts:133:49 at src/tabs/__integ__/tabs.test.ts:77:5 at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
RETRY 3: does not scroll when using arrows: src/tabs/__integ__/tabs.test.ts#L133
expect(received).resolves.toBe(expected) // Object.is equality Expected: 0 Received: 1 at Object.toBe (node_modules/expect/build/index.js:174:22) at src/tabs/__integ__/tabs.test.ts:133:49 at src/tabs/__integ__/tabs.test.ts:77:5 at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
RETRY 1: left/right arrow should have aria-disabled when first/last tab is selected: src/tabs/__integ__/tabs.test.ts#L142
expect(received).resolves.toBe(expected) // Object.is equality Expected: false Received: true at Object.toBe (node_modules/expect/build/index.js:174:22) at src/tabs/__integ__/tabs.test.ts:142:81 at src/tabs/__integ__/tabs.test.ts:77:5 at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
RETRY 2: left/right arrow should have aria-disabled when first/last tab is selected: src/tabs/__integ__/tabs.test.ts#L142
expect(received).resolves.toBe(expected) // Object.is equality Expected: false Received: true at Object.toBe (node_modules/expect/build/index.js:174:22) at src/tabs/__integ__/tabs.test.ts:142:81 at src/tabs/__integ__/tabs.test.ts:77:5 at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
RETRY 3: left/right arrow should have aria-disabled when first/last tab is selected: src/tabs/__integ__/tabs.test.ts#L142
expect(received).resolves.toBe(expected) // Object.is equality Expected: false Received: true at Object.toBe (node_modules/expect/build/index.js:174:22) at src/tabs/__integ__/tabs.test.ts:142:81 at src/tabs/__integ__/tabs.test.ts:77:5 at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
RETRY 1: scrolls when clicking on left/right pagination buttons: src/tabs/__integ__/tabs.test.ts#L160
expect(received).resolves.toBe(expected) // Object.is equality Expected: false Received: true at Object.toBe (node_modules/expect/build/index.js:174:22) at src/tabs/__integ__/tabs.test.ts:160:82 at src/tabs/__integ__/tabs.test.ts:77:5 at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
dry-run / Components accessibility tests shard (2)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/download-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
dry-run / Demos tests
React Hook useEffect has a missing dependency: 'loadCallback'. Either include it or remove the dependency array. If 'loadCallback' changes too often, find the parent component that defines it and wrap that definition in useCallback
dry-run / Demos tests
'React' is defined but never used
dry-run / Demos tests
'Alert' is defined but never used
dry-run / Demos tests
'ExternalLink' is defined but never used
dry-run / Demos tests
'setVisible' is assigned a value but never used
dry-run / Demos tests
React Hook useEffect has a missing dependency: 'updateDirty'. Either include it or remove the dependency array. If 'updateDirty' changes too often, find the parent component that defines it and wrap that definition in useCallback
dry-run / Demos tests
React Hook useEffect has a missing dependency: 'updateDirty'. Either include it or remove the dependency array. If 'updateDirty' changes too often, find the parent component that defines it and wrap that definition in useCallback
dry-run / Demos tests
'Link' is defined but never used
dry-run / Demos tests
React Hook useEffect has a missing dependency: 'totalCount'. Either include it or remove the dependency array
dry-run / Demos tests
'FormField' is defined but never used
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "components-package", "dependencies". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
components-package
102 MB
dependencies
469 KB