feat: Add i18n #84
feat: Add i18n #84
Conversation
This adds react-i18next and a dropdown to dynamically toggle the language anytime. I also added an English translation which is based on Google Translate since I'm not Chinese and don't speak the language. Should be better than nothing though, with way for improvement by the community
Not sure if all of them broke because of the i18n stuff. But simply mocking the i18n and the connected-react-router component did the trick
|
Wow, Thanks! This is a really big effort! |
|
No worries! I figured if I started using Cloudreve, I needed to add some translation anyway. Although most of it is Google Translate'd for now, so adjusting the translations a bit is probably still necessary |
|
Thanks for the PR, but I have to close it. We're already working on designing i18n support in the backend side, it is planned to he shipped in next few versions. It seems conflicted with your change. |
|
Alright, seems reasonable. Thanks for the heads up! If you need any help with getting i18n up and running on the backend side or need someone to proofread, feel free to get in touch. Also, would you be okay with me leaving the fork open for people to use in the meantime? I think there's a few open issues about it in the backend repo that might benefit from it, even though the translations might be a bit off in some places |
|
Sure! I'll leave it open till official support shipped. |
This adds react-i18next and a dropdown to dynamically toggle the language anytime.
I also added an English translation which is based on Google Translate since I'm not Chinese and don't speak the language. Should be better than nothing though, with way for improvement by the community.
English is the default language for the translation keys, so new developers will have an easier time reading the code. If you would like the keys to be Chinese instead, I can change it back.
As a bonus, I also fixed the unit tests. Some of them were broken due to the i18n adjustments, while most probably didn't work in the first place due to cloudreveApp not being called correctly.