Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of CloudWatch logging, additional policy attachment, and KMS decryption #111

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

LawrenceWarren
Copy link

what

  • Allow optional creation of a CloudWatch logs natively within the module, as logging for Bastion nodes is a common requirement
  • Expand the user_data/amazon-linux.sh script to enable debug logging.
  • Allow optional attachment of additional IAM policies, via a list of provided policy ARNs, so that the bation can optionally have more access
  • Allow optional KMS decryption on the bastion

why

  • Simply, these all seem like sensible options to provide users, and are common use-cases that my company use on our internal fork.
  • These changes are not breaking.

cc-robertson and others added 29 commits March 22, 2021 19:26
Ht 4046 | added cloudwatch log group
@LawrenceWarren LawrenceWarren requested a review from a team as a code owner September 6, 2023 11:28
@LawrenceWarren
Copy link
Author

/terratest

1 similar comment
@hans-d
Copy link

hans-d commented Mar 8, 2024

/terratest

@hans-d hans-d added wip Work in Progress: Not ready for final review or merge and removed wip Work in Progress: Not ready for final review or merge labels Mar 8, 2024
Copy link

mergify bot commented Mar 9, 2024

Thanks @LawrenceWarren for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added the triage Needs triage label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants