support: recovery target variables in helm chart

[sadath-12]

No description provided.

[gbartolini]

I see you added only targetTime. Can you please ensure there's a way to add the other recovery targets specified in https://cloudnative-pg.io/documentation/current/recovery/#recovery-targets?

[sadath-12]

sure @gbartolini

[sadath-12]

@gbartolini have a look thanks

[itay-grudev]

What is the purpose of this check?

{{- if or .Values.recovery.pitrTarget.targetTime .Values.recovery.pitrTarget.backupID .Values.recovery.pitrTarget.targetXID .Values.recovery.pitrTarget.targetName .Values.recovery.pitrTarget.targetLSN .Values.recovery.pitrTarget.targetImmediate }}

[itay-grudev]

Can we remove the prefix target?

1. Renaming time to targetTime is a breaking change.
2. It's repetitive. pitrTarget.target.

[itay-grudev]

Can we change the section in the values.yaml to the following:

  pitrTarget:
    # -- The ID of the backup from which to start the recovery process. 
    # If empty (default) the operator will automatically detect the backup based on `pitrTarget.time` or `pitrTarget.lsn` if provided.
    # Otherwise use the latest available backup in chronological order.
    backupID: ""

    # -- Recovery ends as soon as a consistent state is reached, that is, as early as possible
    immediate: ""
    
    # -- The target timeline ("latest" or a positive integer)
    tli: ""

    # -- Set the target to be exclusive. If omitted, defaults to false, so that in Postgres, `recovery_target_inclusive` will be true
    exclusive: ""

    # Specify EXACTLY ONE of the following options:
    # -- Point in time recovery Time target in RFC3339 format
    time: ""
    # -- Point in time recovery Transaction ID up to which recovery proceeds. (The precise stopping point is also influenced by the exclusive option.) 
    xid: ""
    # -- Named restore point (created with pg_create_restore_point()) to which recovery proceeds
    name: ""
    # -- LSN (Log Sequence Number) of the write-ahead log location up to which recovery proceeds. (The precise stopping point is also influenced by the exclusive option.)
    lsn: ""

I've structured it in two sections: the configuration above and the target options below. I've also updated some of the descriptions so they are more accurate.

You were missing the targetTLI and exclusive options. Could you please add those as well?

[sadath-12]

@itay-grudev thanks ,please have a look

[ockhamlabs]

@itay-grudev curious about status of this and if this is planned to be merged?

[itay-grudev]

@ockhamlabs It's getting merged. It's excellent work. I would like to test it and/or write a test suite for it, which is why I haven't merged it yet.

[sadath-12]

Hi @itay-grudev , gentle reminder

[ockhamlabs]

@itay-grudev Thanks and let us know if this can be merged now?

[riddhithummar]

When is this expected to be merged?