-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Me 18059 esm tests over preview build #727
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
5e0cc4f
vp test: support esm test running on preview deploy
ShayLevi a6edc9a
vp test: support esm test running on preview deploy increase timeout
ShayLevi 6409060
vp test: support esm test running on preview deploy revert timeout
ShayLevi 96b8aab
vp test: adding waitFor function for checking if preview URL is ready
ShayLevi 105d995
vp test: adding waitFor function for checking if preview URL is ready
ShayLevi 384f252
vp test: adding waitFor function for checking if preview URL is ready
ShayLevi a8cf2a3
vp test: modify changes
ShayLevi 4b68609
vp test: modify changes
ShayLevi ede3ca1
vp test: modify waitForDeployPreviewUrl
ShayLevi 0ac494e
vp test: modify waitForDeployPreviewUrl
ShayLevi 38a291d
vp test: modify changes
ShayLevi 41a9c3f
vp test: modify changes
ShayLevi e7c3d53
vp test: remove beforeAll
ShayLevi b73bfe1
vp test: modify waitForDeployPreviewUrl function
ShayLevi 064cd30
vp test: modify waitForDeployPreviewUrl function
ShayLevi f69490c
vp test: modify waitForDeployPreviewUrl function
ShayLevi 0903c8c
vp test: modify waitForDeployPreviewUrl function adding a print
ShayLevi a911323
vp test: modify changes
ShayLevi c3c769f
vp test: adding print to log + increasing timeout
ShayLevi 4475231
vp test: revert timeout
ShayLevi 1687533
vp test: adding timeout
ShayLevi 95b9b42
vp test: adding test for is deploy URL ready
ShayLevi f8ea78a
vp test: revert test
ShayLevi 21a560e
vp test: change assertion
ShayLevi 34323b9
vp test: change assertion
ShayLevi ff388d8
vp test: modify waitForDeployPreviewUrl
ShayLevi 744e67e
vp test: modify waitForDeployPreviewUrl assertion
ShayLevi 513c68a
vp test: adding beforeEach and modify waitForDeployPreviewUrl
ShayLevi c163e38
vp test: modify waitForDeployPreviewUrl
ShayLevi cc8de1c
vp test: adding logs for debugging
ShayLevi 47e85ad
vp test: adding logs for debugging
ShayLevi c31ebfb
vp test: adding logs for debugging
ShayLevi dfdfa21
vp test: adding logs for debugging
ShayLevi f0e31f9
vp test: adding logs for debugging
ShayLevi 44deeab
vp test: modify waitForDeployPreviewUrl and revert debugging prints
ShayLevi 3fca8c0
vp test: modify waitForDeployPreviewUrl
ShayLevi b1286a0
vp test: refactor based on review comments
ShayLevi 636a3ca
vp test: remove console log print
ShayLevi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you have to increase the timeout?
(just curious why you needed this change)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i see now it is for the deployment preview to be loaded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The page can take some time to be loaded so the timeout was increased.