fix: one event for internal analytics (#728)

* fix: one event for internal analytics
cloudinary · Nov 7, 2024 · 7552998 · 7552998
1 parent e6c9a9c
commit 7552998
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/plugins/cloudinary/index.js b/src/plugins/cloudinary/index.js
@@ -90,7 +90,7 @@ class CloudinaryContext {
         refresh();
       }
 
-      this.player.trigger('cldsourcechanged', { source: src });
+      this.player.trigger('cldsourcechanged', { source: src, sourceOptions: options });
 
       return _chainTarget;
     };

diff --git a/src/video-player.js b/src/video-player.js
@@ -475,8 +475,8 @@ class VideoPlayer extends Utils.mixin(Eventable) {
     }
   }
 
-  _onSourceChange() {
-    this._sendInternalAnalytics();
+  _onSourceChange(e, { sourceOptions }) {
+    this._sendInternalAnalytics({ ...(sourceOptions ?? { source: sourceOptions }) });
     // #if (!process.env.WEBPACK_BUILD_LIGHT)
     this._initQualitySelector();
     // #endif
@@ -541,8 +541,6 @@ class VideoPlayer extends Utils.mixin(Eventable) {
       });
     }
 
-    this._sendInternalAnalytics({ source: options });
-
     if (publicId instanceof VideoSource) {
       return this.videojs.cloudinary.source(publicId, options);
     }