Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fix URL path for childProcess.fork when using Pleasantest from ESM #726

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

calebeby
Copy link
Member

childProcess.fork does not accept a file:// path. It requires a regular path. The resolveFileUrl function I put in the rollup config returned a file:// path for ESM bundles and a regular path for CJS bundles. This meant that CJS bundles worked but ESM bundles didn't. This PR removes the resolveFileUrl in favor of rollup's built-in version, which always returns a file:// path. Then when we pass it to childProcess.fork we use fileURLToPath to switch it back.

Unfortunately we don't have any test cases for using Jest's experimental ESM with pleasantest. I manually created a repo to test this. I hope to add a monorepo setup to pleasantest so that we can create test cases with Jest's experimental ESM without forcing us to switch all our tests over.

Copy link
Member

@Paul-Hebert Paul-Hebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem reasonable to me, especially if you've tested them in another repo 👍

@calebeby calebeby merged commit e71e259 into main Aug 23, 2023
5 checks passed
@calebeby calebeby deleted the fix-es-fork-url branch August 23, 2023 16:41
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants