Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs about the 'bpm.enabled' property #359

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+15 −1
Open

Improve docs about the 'bpm.enabled' property #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion jobs/garden/spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,21 @@ properties:
default: false

bpm.enabled:
description: "Use bpm. NOTE: this requires a recreate when enabling for the first time, otherwise old containers may be left running. NOTE: When this property is enabled, containers won't survive a restart of the garden job. This is why garden.destroy_containers_on_start should be set to avoid leaking container state."
description: |
Use BPM to run garden.

This in incompatible with recent stemcells that use systemd. Indeed,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgandon I think by recent you mean noble, correct ? If so, it'd better for use the code-name instead.

then only way for sysyemd not to mess up with the garden-managed cgroups
(whether in containerd mode or not), is to run garden as a systemd
service with the 'Delegate=yes' property. Bosh-Lite (Warden) stemcells
are a noticable exception, as these don't use systemd.

Changing this property requires a recreate when enabling for the first
time, otherwise old containers may be left running.

When this property is enabled, containers won't survive a restart of the
garden job. This is why 'garden.destroy_containers_on_start' should be
set to 'true' to avoid leaking container state.
default: false

logging.format.timestamp:
Expand Down