Test backfill

- return an error if unable to 'wait' on the invoked umount process [#171189875](https://www.pivotaltracker.com/story/show/171189875) Authored-by: Dennis Leon <[email protected]>
cloudfoundry-attic · Feb 12, 2020 · afaacbf · afaacbf
1 parent 30d1798
commit afaacbf
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/nodeserver/node_server.go b/nodeserver/node_server.go
@@ -85,7 +85,7 @@ func (n noOpNodeServer) NodeUnpublishVolume(c context.Context, r *csi.NodeUnpubl
 
 	err = cmdshim.Wait()
 	if err != nil {
-		println(err.Error())
+		return nil, status.Error(codes.Internal, err.Error())
 	}
 	log.Printf("finished umount")
 

diff --git a/nodeserver/node_server_test.go b/nodeserver/node_server_test.go
@@ -171,5 +171,17 @@ var _ = Describe("NodeServer", func() {
 				Expect(err.Error()).To(Equal("rpc error: code = Internal desc = start-failed"))
 			})
 		})
+
+		Context("when the command fails to wait", func() {
+
+			BeforeEach(func() {
+				fakeCmd.WaitReturns(errors.New("wait-failed"))
+			})
+
+			It("should return an error", func() {
+				Expect(err).To(HaveOccurred())
+				Expect(err.Error()).To(Equal("rpc error: code = Internal desc = wait-failed"))
+			})
+		})
 	})
 })