Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement a shutdown signal listener function #153

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gengteng
Copy link
Contributor

Hi,

In this PR, I've tackled two TODO items related to our server's signal handling for shutdown and upgrade processes:

  1. Centralized Signal Listening: Introduced a function to listen for shutdown signals, streamlining previous scattered logic.
  2. Enhanced Graceful Upgrades: Ensured rapid shutdown signals are considered during upgrades, bolstering the process's reliability.

These changes aim to clarify and refine our approach, potentially aligning with the original design intentions. I'm curious to hear if this matches our design goals or if there's a preferred direction.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants