Fixed issue caused by config names that have uppercase characters #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enis
reviewed
Jul 27, 2023
|
Updated the logic so that key names remain case insensitive, but profile name are now case sensitive. |
We decided to follow the Python CDP CLI semantics for case sensitivity to be compatible between the two tools and least surprises to the end user. Python INI file parsing defaults to case sensitive section names, but case insensitive option names. We do the same in the go SDK. This commit adds some more unit tests.
enis
approved these changes
Jul 28, 2023
balazsgaspar
added a commit
that referenced
this pull request
Aug 1, 2023
* Fixed issue caused by config names that have uppercase characters * Fixed unit test and add more test cases We decided to follow the Python CDP CLI semantics for case sensitivity to be compatible between the two tools and least surprises to the end user. Python INI file parsing defaults to case sensitive section names, but case insensitive option names. We do the same in the go SDK. This commit adds some more unit tests. --------- Co-authored-by: Enis Soztutar <[email protected]>
gregito
pushed a commit
that referenced
this pull request
Aug 2, 2023
… (#41) * Fixed issue caused by config names that have uppercase characters * Fixed unit test and add more test cases We decided to follow the Python CDP CLI semantics for case sensitivity to be compatible between the two tools and least surprises to the end user. Python INI file parsing defaults to case sensitive section names, but case insensitive option names. We do the same in the go SDK. This commit adds some more unit tests. --------- Co-authored-by: Enis Soztutar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CDPCP-10052