CDPCP-9511 Ability to set CDP Region #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDP Control plane has multiple regions, but we lacked the ability to set the region to send the API requests to in the TF provider. We were defaulting to the us-west-1 region of the control plane. With this change, I have added the cdp_region attribute to the provider configuration and support for the same in the cdp-sdk-go. Similar to CDP CLI and Java SDK, we support setting the region either from the provider, or from env variables or from the CDP config file. The changes to the docs hopefully make it clear for the end user to configure this. I have also done some light cleanup to the tests and reformatted the tf code and regenerated docs. Testing done: - New and existing unit tests - Tested manually by setting the region to eu-1 in my local profile
daszabo
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDP Control plane has multiple regions, but we lacked the ability to set the region to send the API requests to in the TF provider. We were defaulting to the us-west-1 region of the control plane.
With this change, I have added the cdp_region attribute to the provider configuration and support for the same in the cdp-sdk-go. Similar to CDP CLI and Java SDK, we support setting the region either from the provider, or from env variables or from the CDP config file. The changes to the docs hopefully make it clear for the end user to configure this.
I have also done some light cleanup to the tests, reformatted the tf code, regenerated docs and added error propogation for the config value getters (previous we were swallowing errors).
Testing done: