Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWX-18780 Acceptance tests for DW AWS cluster resource #161

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

tevesz
Copy link
Contributor

@tevesz tevesz commented Sep 4, 2024

  • Adding acceptance tests for DW AWS cluster resource
  • Fixed polling options to function correctly

- Adding acceptance tests for DW AWS cluster resource
- Fixed polling options to function correctly
@tevesz tevesz requested a review from a team as a code owner September 4, 2024 21:26
Copy link

github-actions bot commented Sep 4, 2024

Go test coverage: 32.6% for commit 5be5814
⚠️ 2 of 13 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/de
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                        | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest               |    26.9%
+ github.com/cloudera/terraform-provider-cdp/provider                 |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub        |    36.3%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake       |     8.4%
- github.com/cloudera/terraform-provider-cdp/resources/de             |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw             |    83.3%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/cluster/aws |    72.4%
+ github.com/cloudera/terraform-provider-cdp/resources/environments   |    45.7%
+ github.com/cloudera/terraform-provider-cdp/resources/iam            |     2.8%
- github.com/cloudera/terraform-provider-cdp/resources/ml             |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb           |    25.3%
+ github.com/cloudera/terraform-provider-cdp/utils                    |    51.3%
+ github.com/cloudera/terraform-provider-cdp/utils/test               |    68.8%

Copy link

@vcsomor vcsomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just for curiosity: How long does this take to run?

@tevesz
Copy link
Contributor Author

tevesz commented Sep 11, 2024

LGTM! Just for curiosity: How long does this take to run?

It takes around 2 hours

@tevesz tevesz merged commit fa52a95 into main Sep 11, 2024
9 checks passed
@tevesz tevesz deleted the DWX-18780 branch September 11, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants