Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWX-18776 Wait for dw aws cluster to become ready #159

Merged
merged 1 commit into from
Aug 28, 2024
Merged

DWX-18776 Wait for dw aws cluster to become ready #159

merged 1 commit into from
Aug 28, 2024

Conversation

tevesz
Copy link
Contributor

@tevesz tevesz commented Aug 24, 2024

This change awaits the data warehouse aws cluster creation to finish and move the cluster to a Running or Error state.

@tevesz tevesz requested a review from a team as a code owner August 24, 2024 04:06
Copy link

github-actions bot commented Aug 24, 2024

Go test coverage: 32.6% for commit edf69f1
⚠️ 2 of 13 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/de
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                        | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest               |    26.9%
+ github.com/cloudera/terraform-provider-cdp/provider                 |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub        |    36.3%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake       |     8.4%
- github.com/cloudera/terraform-provider-cdp/resources/de             |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw             |    83.3%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/cluster/aws |    72.6%
+ github.com/cloudera/terraform-provider-cdp/resources/environments   |    45.7%
+ github.com/cloudera/terraform-provider-cdp/resources/iam            |     2.8%
- github.com/cloudera/terraform-provider-cdp/resources/ml             |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb           |    25.3%
+ github.com/cloudera/terraform-provider-cdp/utils                    |    51.3%
+ github.com/cloudera/terraform-provider-cdp/utils/test               |    68.8%

vcsomor
vcsomor previously approved these changes Aug 26, 2024
resources/dw/cluster/aws/resource_cluster.go Outdated Show resolved Hide resolved
resources/dw/cluster/aws/resource_cluster.go Outdated Show resolved Hide resolved
resources/dw/cluster/aws/resource_cluster.go Outdated Show resolved Hide resolved
resources/dw/cluster/aws/resource_cluster.go Outdated Show resolved Hide resolved
resources/dw/cluster/aws/resource_cluster.go Outdated Show resolved Hide resolved
resources/dw/cluster/aws/resource_cluster.go Outdated Show resolved Hide resolved
resources/dw/cluster/aws/resource_cluster.go Outdated Show resolved Hide resolved
vcsomor
vcsomor previously approved these changes Aug 27, 2024
Copy link

@vcsomor vcsomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this patch!

This change awaits the data warehouse aws cluster creation to finish
and move the cluster to a Running or Error state.
@tevesz tevesz merged commit 85254d9 into main Aug 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants