Add partitions to table index like PyHive does #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions like PyHive does
Open
timarmstrong
reviewed
Mar 7, 2019
| break | ||
| # Handle partition columns | ||
| col_names = [] | ||
| for col_name, _col_type, _comment in rows[i + 1:]: |
There was a problem hiding this comment.
How does this work? It seems like this is going to process all of the "DESCRIBE FORMATTED" output after "#Partition Information" regardless of whether it's a comment or not.
There was a problem hiding this comment.
My best guess is # Partition Information was last in describe output at that time in impala. Will add a fix in the next few days when I catch some time.
|
Thanks Ivan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.