Added the new SqlOptimizer and the related files #3284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and store it in a table/DB
bjornalm
requested changes
Apr 21, 2023
| @@ -953,7 +954,21 @@ huePubSub.subscribe('app.dom.loaded', app => { | |||
| huePubSub.subscribe( | |||
| 'editor.upload.query', | |||
| query_id => { | |||
| viewModel.selectedNotebook().snippets()[0].uploadQuery(query_id); | |||
| const useInternalHueOptimizerStorage = true; | |||
There was a problem hiding this comment.
We need to turn this into a setting. Preferably accessed from desktop/core/src/desktop/js/config/hueConfig.ts (which should load the setting from the backend). The setting itself should be placed in desktop/conf.dist/hue.ini and be false by default so that we don't expose this to our clients by mistake.
|
This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The new SqlParser along with its functionality was added.
How was this patch tested?
This patch was tested using mutiple console.log() statements and finally getting to the correct code.