-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the new SqlOptimizer and the related files #3284
Conversation
… and store it in a table/DB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, work. Just a quick review from me here to unblock further progress.
@@ -953,7 +954,21 @@ huePubSub.subscribe('app.dom.loaded', app => { | |||
huePubSub.subscribe( | |||
'editor.upload.query', | |||
query_id => { | |||
viewModel.selectedNotebook().snippets()[0].uploadQuery(query_id); | |||
const useInternalHueOptimizerStorage = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to turn this into a setting. Preferably accessed from desktop/core/src/desktop/js/config/hueConfig.ts (which should load the setting from the backend). The setting itself should be placed in desktop/conf.dist/hue.ini and be false by default so that we don't expose this to our clients by mistake.
This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days. |
What changes were proposed in this pull request?
The new SqlParser along with its functionality was added.
How was this patch tested?
This patch was tested using mutiple console.log() statements and finally getting to the correct code.