[CYB-193][UI] Landing page for pipelines. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Build fix.
# Conflicts: # .github/workflows/build_and_test.yml # flink-cyber/cyber-services/cyber-worker-service/pom.xml # flink-cyber/metron-parser-chain/parser-chains-config-service/src/main/java/com/cloudera/parserchains/queryservice/controller/ChainController.java # flink-cyber/metron-parser-chain/parser-chains-config-service/src/main/java/com/cloudera/parserchains/queryservice/controller/ClusterController.java # flink-cyber/metron-parser-chain/parser-chains-config-service/src/main/java/com/cloudera/parserchains/queryservice/controller/JobController.java # flink-cyber/metron-parser-chain/parser-chains-config-service/src/main/java/com/cloudera/parserchains/queryservice/controller/PipelineController.java
* initial commit with new pages. * refactor old page for chains list.
…eate_datahub_config.sh setup script (#76)
* fix build.
* fix build.
* fix build.
* Fix ui issue with popup windows.
* Fix some minor issue.
* Fix some minor issue.
vpavlenko-cv
added
checked on a cluster
stas-panasiuk
approved these changes
Oct 15, 2024
| @@ -37,6 +44,7 @@ | |||
| @Slf4j | |||
| @EnableKafka | |||
| @Configuration | |||
| @Profile("kafka") | |||
There was a problem hiding this comment.
Without this profile the entire application doesn't work
Comment on lines
+21
to
+30
| // return values.pipe( | ||
| // map(items => { | ||
| // if (column) { | ||
| // const b = items.some(el => el[column] === uniqVal); | ||
| // return b ? {uniqueValue: true} : null; | ||
| // } | ||
| // return items.some(uniqVal) ? {uniqueValue: true}: null; | ||
| // }), | ||
| // first() | ||
| // ); |
There was a problem hiding this comment.
this might be worth removing
Comment on lines
+31
to
+35
| // it('should have buttons as per @Input', () => { | ||
| // component.buttons = [ {label: "Test1", value: "Value1"}, {label: "Test2", value: "Value2"} ]; | ||
| // expect(component.buttons.length).toBe(2); | ||
| // expect(component.buttons.map(button => button.label)).toEqual(['Test1', 'Test2']); | ||
| // }); |
There was a problem hiding this comment.
once again, commented code is better to keep off-codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.