Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be loading configs in
setup_benchmark
rather thanrun_benchmark
so that everything necessary to run the benchmark is prepared in setup. This makes it very handy for testing out various driver functions without having to run a proper benchmark.Having to pass the configs into
run_benchmark
as well is a bit awkward, but it kind of makes sense as loading the config is a different action than copying the config into the log directory for actually running the benchmark. I'm open to alternative suggestions, but I think this is fine for a first pass, especially since it allows us to develop drivers interactively.