Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent TypeError when task json data missing #114

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prevent TypeError when task json data missing #114

wants to merge 2 commits into from

Conversation

alanhamlett
Copy link
Contributor

@alanhamlett alanhamlett commented Aug 14, 2018

Related to #112.

This prevents an exception when calling Task.tasks_from_queue, but this doesn't fix the root problem of the task being created with invalid json data:

serialized_task = json.dumps(self._data)

@thomasst
Copy link
Member

this doesn't fix the root problem of the task being created with invalid json data:

I've seen this sometimes, but usually only if I manually messed with Redis to clear keys and didn't properly clean up, in which case the key doesn't exist.

I thought of making this change as well, but I think I'd prefer us to fail explicitly here.

Any further thoughts @jkemp101 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants