Don't include html_top in a no-message forward #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #14
I'm not sure if I fixed the root cause of it, did my best to understand what's happening here.
The
top_range
inunwrap_html
would be an interval like(0, 1)
and thetrim_slice
would make it(1, 1)
which I think is wrong to pass it along toslice_tree
after.Since
slice_tree
now receives a wrong interval sincestart_refs[1]
appears afterend_refs[1]
so it's quite unusual situation. To be precise, inslice_tree
:and by checking the HTML of the test
HTMLUnwrapTestCase.test_gmail_forward_no_message
you can see what I'm referring to that end appears before the start.