-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.3.1 #150
Release v2.3.1 #150
Conversation
83f1415
to
63981a8
Compare
@AlecRosenbaum I manually ran the GitHub Action against this PR, and it wasn't producing wheels for 3.12. I believe this is because you need to re-vendor the Once that is solved, and the wheels are being built successfully by the GitHub Action:
|
I've re-sync'd our fork of |
I assume the pin needs to be bumped here so it builds for 3.12 too? Then I can do the manual steps to upload them to pypi |
@AlecRosenbaum, I bumped the version used in the workflow, but it didn't find the new tag. |
Ah, I pressed the sync fork button in the github UI not realizing it doesn't sync tags too. I've now pushed them manually from the CLI and they should now be present |
@AlecRosenbaum Thank. I ran the workflow again, and it worked. 🎉 Next steps:
|
I've uploaded the artifacts to PyPi: https://pypi.org/project/ciso8601/2.3.1/ |
I confirmed that I can install |
What are you trying to accomplish?
New release for Python 2.3.1 wheels.
What approach did you choose and why?
Bumped the patch version number.
What should reviewers focus on?
You can verify the commits made between since the last release do not contain other changes.
The impact of these changes
Users of Python 3.12 will have pre-built wheels. Fixes #146.
Testing
You can download the artifacts and install them yourself in a local virtual environment.