Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.3.1 #150

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Release v2.3.1 #150

merged 2 commits into from
Oct 28, 2023

Conversation

movermeyer
Copy link
Collaborator

@movermeyer movermeyer commented Oct 25, 2023

What are you trying to accomplish?

New release for Python 2.3.1 wheels.

What approach did you choose and why?

Bumped the patch version number.

What should reviewers focus on?

You can verify the commits made between since the last release do not contain other changes.

The impact of these changes

Users of Python 3.12 will have pre-built wheels. Fixes #146.

Testing

You can download the artifacts and install them yourself in a local virtual environment.

@movermeyer movermeyer marked this pull request as ready for review October 25, 2023 19:08
@movermeyer movermeyer marked this pull request as draft October 25, 2023 19:12
@movermeyer movermeyer force-pushed the movermeyer/release_2_3_1 branch 2 times, most recently from 83f1415 to 63981a8 Compare October 25, 2023 19:33
@movermeyer
Copy link
Collaborator Author

movermeyer commented Oct 25, 2023

@AlecRosenbaum I manually ran the GitHub Action against this PR, and it wasn't producing wheels for 3.12. I believe this is because you need to re-vendor the cibuildwheel GitHub Action (closeio/[email protected] -> closeio/[email protected]).


Once that is solved, and the wheels are being built successfully by the GitHub Action:

  1. This PR needs to be approved and merged
  2. The artifacts need to be uploaded as a new release on PyPI (I don't have permissions to do this)
  3. The GitHub Release needs to be published, with the date added to the description (I can do this)

@AlecRosenbaum
Copy link
Collaborator

I've re-sync'd our fork of cibuildwheel, so it should have the new tag now

@AlecRosenbaum
Copy link
Collaborator

I assume the pin needs to be bumped here so it builds for 3.12 too? Then I can do the manual steps to upload them to pypi

@movermeyer
Copy link
Collaborator Author

I've re-sync'd our fork of cibuildwheel, so it should have the new tag now

@AlecRosenbaum, I bumped the version used in the workflow, but it didn't find the new tag.

@AlecRosenbaum
Copy link
Collaborator

Ah, I pressed the sync fork button in the github UI not realizing it doesn't sync tags too.

I've now pushed them manually from the CLI and they should now be present

@movermeyer movermeyer marked this pull request as ready for review October 28, 2023 13:20
@movermeyer
Copy link
Collaborator Author

movermeyer commented Oct 28, 2023

I've now pushed them manually from the CLI and they should now be present

@AlecRosenbaum Thank. I ran the workflow again, and it worked. 🎉

Next steps:

  1. The artifacts need to be uploaded as a new release on PyPI (I don't have permissions to do this)
  2. The GitHub Release needs to be published, with the date added to the description (I can do this)

@movermeyer movermeyer merged commit b17984f into master Oct 28, 2023
24 of 27 checks passed
@AlecRosenbaum
Copy link
Collaborator

I've uploaded the artifacts to PyPi: https://pypi.org/project/ciso8601/2.3.1/

@AlecRosenbaum
Copy link
Collaborator

I confirmed that I can install ciso8601==2.3.1 locally from wheels on python 3.12, and did a few basic checks that it was working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No wheel for Python 3.12
2 participants