Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve hardcoded Java home #4

Merged
merged 5 commits into from
Dec 31, 2023
Merged

Resolve hardcoded Java home #4

merged 5 commits into from
Dec 31, 2023

Conversation

ajoberstar
Copy link
Member

Related issues:

Contributor Checklist

  • Review Contributing Guidelines.
  • Commits contain discrete changes, messages include context about why the change was made and reference the relevant issues.
  • Commit messages should be prefixed with one of the following (these are used to determine the next version we release):
    • patch: if the change added no new functionality and is backwards compatible
    • minor: if the change added new functionality and is backwards compatible
    • major: if the change is not backwards compatible
    • chore: if the change doesn't affect plugin logic/behavior at all (and obviously still backwards compatible)
    • Any of these can optionally specify an area of the plugin they affected in parentheses (e.g. patch(clojurescript): )
      • build
      • docs
      • clojure
      • clojurescript
  • Provide functional tests.
  • Update documentation for user-facing changes. (under docs/)
  • Ensure all verification tasks pass locally. (./gradlew check)
  • Ensure CI builds pass on all Java versions. (watch the checks tab once the PR is opened)

TIP: If troubleshooting a CI failure, look for the build scan URL in the workflow run summary.

@ajoberstar ajoberstar marked this pull request as ready for review December 31, 2023 06:28
@ajoberstar ajoberstar merged commit 1e04e65 into main Dec 31, 2023
1 check passed
@ajoberstar ajoberstar deleted the update branch December 31, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant