[complete] Prioritize flex style if flex style is requested #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yakushev
force-pushed
the
flex-first
branch
from
ae19fe2
to
7b5515a
Compare
alexander-yakushev
force-pushed
the
flex-first
branch
from
7b5515a
to
1f16f75
Compare
bbatsov
reviewed
Jun 2, 2024
| @@ -297,7 +297,7 @@ Only affects the `cider' completion category.`" | |||
| (unless found-styles | |||
| (setq found-styles '(styles basic))) | |||
| (unless (member 'flex found-styles) | |||
| (setq found-styles (append found-styles '(flex)))) | |||
| (setq found-styles (apply #'list 'styles 'flex (cdr found-styles)))) | |||
There was a problem hiding this comment.
Maybe you can add here a comment similar to the description of the ticket, so people would understand better the need for this bit of code. Feel free do directly commit the comment if you agree with me it'd be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been briefly discussed here #3659 (comment) before making
basicthe prioritized one.The current setup produces a bug when Compliment returns a list of candidates that matches
flexstyle, but only one of the items on that list matchesbasicstyle. In that case, Emacs will eagerly complete that single candidate without presenting a list.Example:
Unsainstantly completes toUnsatisfiedLinkError(because that's a class that is always imported to all namespaces).Desired behavior: