Don't require cider-log eagerly
#3473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It adds a some startup performance overhead (as it has transitive dependencies), and most importantly, its https://github.com/magit/transient dep appears to have an issue under Emacs 29 (I'm currently investigating it prior to reporting it).
|
Looks like a safe change to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The now-removed
requirewas adding some startup performance overhead (as it has transitive dependencies), and most importantly, its https://github.com/magit/transient dep appears to have an issue under Emacs 29 (I'm currently investigating it prior to reporting it).cider-log.el has autoloads in place - only one was missing so the
requireremoval seems safe. Still, I'd be much thankful you could try it out - I still haven't gotten to try out cider-log as I'm busy with misc features.Cheers - V