Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

middleware_setup.adoc: add instructions for refactor-nrepl #3464

Closed
wants to merge 2 commits into from

Conversation

vemv
Copy link
Member

@vemv vemv commented Sep 13, 2023

  • Upgrade refactor-nrepl references in tests
  • middleware_setup.adoc: add instructions for refactor-nrepl

...I don't feel too strongly about this one, but seems a sensible improvement (aligned with https://docs.cider.mx/cider/cljs/shadow-cljs.html which also suggests refactor-nrepl).

Cheers - V

@vemv vemv requested a review from bbatsov September 13, 2023 13:17
@bbatsov
Copy link
Member

bbatsov commented Sep 13, 2023

Hmmm, I'll have to think about this. I've intentionally avoided refactor-nrepl in most of the docs, just because so many issues historically came from people trying clj-refactor.el without them knowing what they're are doing. Given that people are often new to both Emacs and Clojure a more complex setup is a recipe for issues IMO.

@vemv
Copy link
Member Author

vemv commented Sep 13, 2023

That's reasonable.

Maybe I can include the code preceded by #_?

@bbatsov
Copy link
Member

bbatsov commented Sep 13, 2023

I think it's best to just keep this out of CIDER's docs.

@vemv
Copy link
Member Author

vemv commented Sep 13, 2023

No issue!

@vemv vemv closed this Sep 13, 2023
@vemv vemv deleted the docs-misc branch October 29, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants