Also match friendly sessions based on the buffer's ns form #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
commented
Aug 22, 2023
| @@ -615,64 +615,6 @@ REPL defaults to the current REPL." | |||
|
|
|||
| (declare-function cider-classpath-entries "cider-client") | |||
|
|
|||
| (defun cider--sesman-friendly-session-p (session &optional debug) | |||
There was a problem hiding this comment.
Because the new impl uses misc variables/defuns like cider-repl-ns-cache, cider-sync-request:ns-list, I had to move it, keeping the linter happy.
tbh it makes sense to me that if this code now uses more repl-based capabilities, it's defined in cider-repl.el.
An alternative possibly being declare-function?
There was a problem hiding this comment.
I'm not a big fan of declare-function, so let's keep it moved.
Comment on lines
+1768
to
+1772
| (ns-list (or (process-get proc :all-namespaces) | ||
| (let ((ns-list (with-current-buffer repl | ||
| (cider-sync-request:ns-list)))) | ||
| (process-put proc :all-namespaces ns-list) | ||
| ns-list))) |
Comment on lines
+1796
to
+1804
| (when-let ((ns (condition-case nil | ||
| (substring-no-properties (cider-current-ns :no-default)) | ||
| (error nil)))) | ||
| ;; if the ns form matches with a ns of all runtime namespaces, we can consider the buffer to match | ||
| ;; (this is a bit lax, but also quite useful) | ||
| (with-current-buffer repl | ||
| (or (when cider-repl-ns-cache ;; may be nil on repl startup | ||
| (member ns (nrepl-dict-keys cider-repl-ns-cache))) | ||
| (member ns ns-list)))) |
There was a problem hiding this comment.
Looks good to me. At some point it'd be nice to comment all the cases for a friendly session as the function is now huge and it's kind of hard to follow.
|
Looks good to me now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample use case:
No linked CIDER sessions), because the ns form won't match with Haystack's ns listThe "ns list" is basically:
(all-ns), computed oncecider-repl-ns-cache, i.e. the changed namespaces as conveyed bytrack-state.Cheers - V